There are many options to improve your software quality.
One of the most effective methods is to do code reviews with other developers.
Code reviews are as much a social interaction as a technical best practice. In a healthy engineering culture (egoless), team members engage their peers to improve the quality of their code and increase their productivity. Developers understand that the time they spend looking at a colleague’s code is repaid when other team members examine their own deliverables. These days, most of the companies (e.g. Facebook, Netflix, Google, Amazon, Uber) are embracing it, so it’s another sign that something is working well here.
The important thing to remember when you are doing a code review is to be kind and to ask questions (clarifications) before you suggesting anything.
Why Ask For A Peer Review?
- The most basic reason is to find bugs.
If you won’t ask for it, you will miss bugs in your code:
a. Accidental errors – typos or mixing variables.
b. Structural errors – dead code, logic or algorithm bugs, performance or architecture concerns. These are often much easier to spot for an external reviewers the see your work from their perspective.
- You preventing from yourself a great way to learn and get better – Committers are motivated by the notion of a viewer who will look over the change request: the committer tends to clean up loose ends, consolidate TODOs, and generally improve the commit.
- Your code is not as clear as you think. Another developer will make it better both from its testability and readability aspects.
Code reviews are very important not only for developers but also to product managers, test engineers, designers and others.
In many cases, developers will be the first ones to see the benefits. It will allow them to move faster and with higher quality. Continue reading